ContributedPartRenderer$1.setFocus: prevent NPE #2367 #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during PartRenderingEngineTests eclipse-platform#2367
Contributor
Author
|
@vogella can you please review, that code comes from you. |
Contributor
Test Results 1 815 files ±0 1 815 suites ±0 1h 42m 32s ⏱️ + 1m 38s For more details on these failures, see this check. Results for commit ed01285. ± Comparison against base commit cc770ec. |
Contributor
|
I assume this is a test only scenario? IPresentationEngine cannot be null in a real application IIRC. Change is fine for me. |
Contributor
Author
yes, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during PartRenderingEngineTests
#2367